renepay: bugfix: read groupids as u64 #7979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
renepay-64bit-groupid
branch
from
381bc9b to
37281bc
Compare
Contributor
|
Rebased on master, fixed gcc -O3 wanting initialization for value (not smart enough to see it's protected by a bool flag). |
Changelog-Fixed: renepay: read groupids as u64 integers. Signed-off-by: Lagrang3 <[email protected]>
Change functions json_pay and json_paystatus to json_renepay and json_renepaystatus to match the conventional naming. This is helpful for grep searches. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
rustyrussell
force-pushed
the
renepay-64bit-groupid
branch
from
37281bc to
05a6b08
Compare
Contributor
|
Logic seems flawed, assert trips when there's a pending payment... (or did I break something in rebase?) |
Lagrang3
force-pushed
the
renepay-64bit-groupid
branch
from
05a6b08 to
27e7bbe
Compare
Searches the first unused groupid and uses that number for the current payment attempt. We previously used the highest value of used groupid + 1, which breaks in a few corner cases. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
force-pushed
the
renepay-64bit-groupid
branch
from
27e7bbe to
728edf3
Compare
Collaborator
|
Looks reasonable and the logic seems to be in good shape now. |
endothermicdev
merged commit a2a186f
into
ElementsProject:master
38 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow renepay to read group ids from listsenpay with values that fit into u64 integer type.
Previously renepay was using a mixture of u32 and u64 types to handle group ids.
Changelog-Fixed: renepay: read groupids as u64 integers.
Fixes #7968